Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement R2 driver #15

Merged
merged 7 commits into from
Jan 10, 2024
Merged

Conversation

aomerk
Copy link
Contributor

@aomerk aomerk commented Jan 3, 2024

Manually tested:

  • pushing various images, including scam-detector (~3gb)
  • pulling various images

Mostly a copy of s3 driver implementation, changes are:

  • dropped settings not supported by cloudflare's R2
  • upgraded aws-sdk to v2

Inspired from distribution proposal to support R2:
distribution/distribution#3940
This draft was deemed to have problems on some systems, but I did not experience issues, at least within our use cases

@aomerk aomerk merged commit 492d7fd into master Jan 10, 2024
1 check passed
@aomerk aomerk deleted the ali/forta-1507-implement-r2-driver-for-disco branch January 10, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants